Greasy Fork

Buttons in "Manage Hiding" not functional

The "Manage Hiding" button still works and can show the menu, but all buttons and tabs have no response when being clicked on.

I managed to find some error info in dev tools.

ReferenceError: i is not defined
    at fixuistyle (chrome-extension://dhdgffkkebhmkfjojejmpbldmpobfkfo/userscript.html?name=Google%2520Hit%2520Hider%2520by%2520Domain%2520(/Search%2520Filter%2520%252F%2520Block%2520Sites).user.js&id=718a241c-b035-430e-9e58-4cf529bfdd04:1939:9)
    at addManageForm (chrome-extension://dhdgffkkebhmkfjojejmpbldmpobfkfo/userscript.html?name=Google%2520Hit%2520Hider%2520by%2520Domain%2520(/Search%2520Filter%2520%252F%2520Block%2520Sites).user.js&id=718a241c-b035-430e-9e58-4cf529bfdd04:1513:3)
    at GHHbDinit (chrome-extension://dhdgffkkebhmkfjojejmpbldmpobfkfo/userscript.html?name=Google%2520Hit%2520Hider%2520by%2520Domain%2520(/Search%2520Filter%2520%252F%2520Block%2520Sites).user.js&id=718a241c-b035-430e-9e58-4cf529bfdd04:319:49)
    at Window.tms_718a241c_b035_430e_9e58_4cf529bfdd04 (chrome-extension://dhdgffkkebhmkfjojejmpbldmpobfkfo/userscript.html?name=Google%2520Hit%2520Hider%2520by%2520Domain%2520(/Search%2520Filter%2520%252F%2520Block%2520Sites).user.js&id=718a241c-b035-430e-9e58-4cf529bfdd04:261:3)
    at <anonymous>:3:98
    at eval (chrome-extension://dhdgffkkebhmkfjojejmpbldmpobfkfo/userscript.html?name=Google%2520Hit%2520Hider%2520by%2520Domain%2520(/Search%2520Filter%2520%252F%2520Block%2520Sites).user.js&id=718a241c-b035-430e-9e58-4cf529bfdd04:1:95)
    at eval (chrome-extension://dhdgffkkebhmkfjojejmpbldmpobfkfo/userscript.html?name=Google%2520Hit%2520Hider%2520by%2520Domain%2520(/Search%2520Filter%2520%252F%2520Block%2520Sites).user.js&id=718a241c-b035-430e-9e58-4cf529bfdd04:1:748)
    at eval (chrome-extension://dhdgffkkebhmkfjojejmpbldmpobfkfo/userscript.html?name=Google%2520Hit%2520Hider%2520by%2520Domain%2520(/Search%2520Filter%2520%252F%2520Block%2520Sites).user.js&id=718a241c-b035-430e-9e58-4cf529bfdd04:2874:6)
    at eval (chrome-extension://dhdgffkkebhmkfjojejmpbldmpobfkfo/userscript.html?name=Google%2520Hit%2520Hider%2520by%2520Domain%2520(/Search%2520Filter%2520%252F%2520Block%2520Sites).user.js&id=718a241c-b035-430e-9e58-4cf529bfdd04:2876:3)
    at eval (<anonymous>)

I tried to disable all other extensions (in incognito mode), but still no luck.

Chrome 83.0.4103.97 (Official Build) (64-bit) Windows 10 Pro Ver 2004 Build 19041.329

Basic features like hiding still work.

I also tried to manually delete and reinstall the script, but the issue still exists.

Hi Rui LIU, thank you for the report. I'm having trouble replicating this problem.

I usually test on Chrome with Tampermonkey, which I think you are using as well.

I usually test on Google.com, logged out of my account. Could you indicate which site you're using and whether you are logged in?

Hi, I tested on Google, in the incognito mode, so my account is logged out.

I also recorded a gif for reproduction.

I went through all the linter objections in the Tampermonkey editor and cleaned up those issues. That should get rid of the original error message you posted, but I have no idea whether that will help with the tabs in the dialog. That cleaned-up code is here -- you can create a new userscript and paste it in for testing (disable the regular script to avoid conflicts):

https://www.jeffersonscher.com/gm/beta/2.1.2.1.user.js.txt

Hi, sorry for the late reply, the cleaned code works well on my machine, and there's no error in the devtools.

Do you have any plan using this version for the next release?

Version 2.1.3 has those fixes, plus hopefully blocking will work in Google Images again.