Discussions » Greasy Fork Feedback

jsdeliver regex is broken

mach6Mod
§
Posted:

The current one:

^(https?:)?//cdn\.jsdelivr\.net/gh/[^/]+/[^/@]+@[a-f0-9]{40}

I guess it should be:

^(https?:)?//cdn\.jsdelivr\.net/gh/[^/]+/[^/@]+@[a-f0-9\.]{1,40}\/.*

This also allows version number like 'v1.0'

wOxxOmMod
§
Posted:
Edited:

A version tag can be switched easily to any other commit by the repository's maintainer so it can't be allowed on GreasyFork if I understand the purpose of the external code policy correctly which is to prevent covert code change after the user inspected the external code at installation/update.

wOxxOmMod
§
Posted:

BTW, @JasonBarnabe, did you decide to not recreate our mod-only forum because you think it's not useful?

§
Posted:
Edited:

Yeah, it's only supposed to be commit-specific. If you want a specific version, then you can use a non-gh URL.

BTW, @JasonBarnabe, did you decide to not recreate our mod-only forum because you think it's not useful?

I think it has minimal usefulness and it would take a bit to implement.

Post reply

Sign in to post a reply.