Greasy Fork

Filters List missing with Firefox 45.9.0 ESR - but is working w/ FF-52.9.0ESR

Hi again. I got a mystery here...

GreasyFork Bullshit Filter(2018.9.12.3) is not working in a [FF 45.9.0ESR (portable)/ GM 3.11] combo.

• Only GBF(2018.4.24) works in a [FF 45.9.0ESR (portable)/ GM 3.11] combo.
• GBF(2018.9.12.3) does work in a [FF 52.9.0ESR (portable)/ GM 3.11] combo.

As noted in this discussion, this might be an issue with the changes in FF versions. But when I diff'ed GBF versions, and the only pointed change that I could note is the new use of '===' vs. older use of '==' in some lines. Tried a manual edit of GBFv2018.9.12.3 but this didn't work.

I did two tests...

[1] I made a clean profile of combo: [FF 45.9.0ESR (portable)/ GM 3.11] -- no other addons, no other scripts: doesn't work --> GBF(2018.9.12.3) works --> GBF(2018.4.24)

[2] a clean profile of combo: [FF 52.9.0ESR (portable)/ GM 3.11] -- no other addons, no other scripts: works --> GBF(2018.9.12.3)

I accept that FF45 is an old version, so I'm not asking to maintain GBF to work with it. Instead, if you can the problem's cause and determine a manual fix, I'll maintain the solution locally.

I diff'ed GBF versions, and the only pointed change that I could note is the new use of '===' vs. older use of '==' in some lines.

The other change is the /u flag in the filter regexes: Firefox started supporting the /u flag from FF46 and on. That's why the script doesn't work for you.

To facilitate you, I've uploaded a new version reverting both === and the /u flag changes.

Thanks for the info!

But you really don't hv2 do that -- I know fewer & fewer people will be using the older versions. I don't want your work stuck in the pre-WebExtensions era.

Can I just remove the /u flags? (And does === matter to FF versions?)

Can I just remove the /u flags?

Yes.

(And does === matter to FF versions?)

No.

But you really don't hv2 do that -- I know fewer & fewer people will be using the older versions.

Ok, I'll restore these changes.

Before I do that, please confirm that the script works for you when you only remove the /u flag (i.e. keeping the ===), so that we may consider your issue solved.

ok, all of these on the clean profile FF 45.9.0ESR:

• I manually edited GBF(2018.9.12.3) /iu to /i -- this didn't work.
• Manually edited removed /i -- this didn't work.
• Decided to just install GBF(2018.9.13) -- this didn't work!

Not sure what's going on.

The profile is totally clean: no addons, no other scripts, no customized user.js, etc.

Let me know if there's any other testing I can try.

You had to also replace/iu to /i to lines 128-131 of the script, something that missed my attention with my 2018.9.13 version as well. Replace them too, and it will surely work fine.

I just restored my additions, and made a minor change to the 'Clutter' filter regex: just --> (just)?

I tested & edited again and now it works!

I checked GBF(2018.9.12.3) and GBF(2018.9.13.1)... btw I normally used GBF with [TS] Citrus, so tested those too -- all is good.

{Just a side-note for anyone else: editing the script(s) with MS WordPad apparently is screwing up the text encoding. I switched back to the default editor, and all is good.}

Thanks for helping sort this out!

I'll keep track of any future script updates, and just do the edits manually.