☰

Greasy Fork is available in English.

Telegram Translations - Fix auto scroll

When switching entry, a function that focus and select the text will also scroll the translation textbox under the page header and cause issues. This script fixes this problem while keep the "focus and select" part of that function.

Autor
Crystal-RainSlide
Dnevne instalacije
0
Ukupno instalacija
75
Ocene
0 0 0
Verzija
1.0
Napravljeno
06/03/2024
Ažurirano
06/03/2024
Licenca
blessing
Važi za

When switching entry, a function that focus and select the text will also scroll the translation textbox under the page header and cause issues.

This script fixes this problem while keep the "focus and select" part of that function.

This one bug hung me for a long time, and I spent hours to trace down its callback hell to reach the real troublemaker:

A func call to $.fn.scrollIntoView(), hidden inside $.fn.focusAndSelect(), which is hide after $.fn.focusAndSelectAll(), which is called by LangKey.showSuggestionForm(), which will be called onclick when switching entry.

LangKey.showSuggestionForm() also does the scroll, animated, but is before that final bad scroll in $.fn.scrollIntoView() and thus useless.

I really think the JavaScript part in Telegram Translations is overengineered.

Refactor it, or maybe do some CSS upgrade like dark theme or densed view... Will be much more helpful than adding all those callbacks and scrolls with hard-to-diagnose issues.