FYTE /Fast YouTube Embedded/ Player

Hugely improves load speed of pages with lots of embedded Youtube videos by instantly showing clickable and immediately accessible placeholders, then the thumbnails are loaded in background. Optionally a fast simple HTML5 direct playback (720p max) can be selected if available for the video.

< Feedback on FYTE /Fast YouTube Embedded/ Player

Review: Good - script works

§
Posted: 2024-06-10

Conflicts with
https://greasyfork.org/en/scripts/1590-no-embed-youtube and with https://greasyfork.org/en/scripts/495214-youtube-link-to-embedded-video

Could you please simply update this script to check for a class/id name of your choice, and if found in the iframe then this script ignores the iframe?

woxxomAuthor
§
Posted: 2024-06-10
Edited: 2024-06-10

How does it conflict specifically? Seems to work for me. Although indeed I can add an option to skip processing dynamically added video frames because the primary point of this script is to make pages load faster.

§
Posted: 2024-06-11

The top right X close button doesn't show up, and the right bottom resizing feature doesn't work on https://greasyfork.org/en/scripts/495214-youtube-link-to-embedded-video on https://www.google.com/search?q=musica+2024&ie=UTF-8&safe=off
But they work on https://myanimelist.net/forum/?topicid=2122764

Many websites load iframes or next pages that have YT videos, so I think that it's very important to keep "processing dynamically added video frames", but I would like an easy option to skip it if I wish, or after a script ran, this would be easy to do if after your script runs, you add an id/class or whatever to the iframe, so I can track that minor change, or I could add it to other scripts, so I could "fool" your script into thinking that it already ran in an iframe because I added an id/class, that your script adds when it modifies an iframe.

This would also be good because then your script wouldn't run over and over on the same iframe it already ran once, since it will check for an id/class, and if it exits then your script won't modify the iframe again.

woxxomAuthor
§
Posted: 2024-06-11

Okay, so do you think it should be 1) an input in the options where the user can type a CSS selector to skip or 2) no option, just skip those in my script 3) fix the bugs?

§
Posted: 2024-06-11

Thanks for your quick response!

4) Add an id/class, that your script adds when it modifies an iframe.

Maybe that will fix the bug? We could try this first.

woxxomAuthor
§
Posted: 2024-06-11
Edited: 2024-06-11

My script removes the iframe, adds its own UI, then adds a new iframe.

§
Posted: 2024-06-11

Oh I see, I can already track it by using 'instant-youtube-wrapper'.

I guess this is a bug that you would have to fix then, me tracking that probably wouldn't fix the issue.

At the "bottom" of this page a problem also happens https://myanimelist.net/profile/hacker09#lastcomment and no YT video is loaded at all

woxxomAuthor
§
Posted: 2024-06-11
Edited: 2024-06-11

Okay, let's fix the bugs.

1. With 495214-youtube-link-to-embedded-video script enabled

https://greasyfork.org/en/scripts/495214-youtube-link-to-embedded-video The top right X close button doesn't show up

What is this button? My script doesn't have it.

right bottom resizing feature

Works for me, assuming the video window is snapped to a corner in the left.

https://www.google.com/search?q=musica+2024&ie=UTF-8&safe=off

My script doesn't intercept these videos on my computer.

2. With 495214-youtube-link-to-embedded-video script enabled and 1590-no-embed-youtube

My script doesn't work because 1590-no-embed-youtube kills the iframe. I can fix it by using ShadowDOM, but that will make my script non-customizable externally via Stylish/Stylus and similar userstyle extensions.

§
Posted: 2024-06-11

I actually don't care about 1590-no-embed-youtube, so let's forget about this one

Resizing should not snapped to a corner in the left, this is a feature of your script, not of 495214-youtube-link-to-embedded-video

Try using 495214-youtube-link-to-embedded-video once without your script on https://www.google.com/search?q=musica+2024&ie=UTF-8&safe=off , then enable your script and you will see the resizing/X close button difference

woxxomAuthor
§
Posted: 2024-06-12

My script doesn't work for me in that google search page, so I don't see any difference with it enabled or disabled. It also doesn't have a close button and the only resizer it has is vertical in corner-snapped mode.

§
Posted: 2024-06-12
Edited: 2024-06-12

I am also seeing the red corners on both right-side corners, that is a feature of your script, because your script runs on google.

Even if it doesn't @match on google, it runs on YT iframes, which that other script creates, which then causes your script to be trigged and run even on google and any other top domain.

The other script has a bottom right side red and resizable corner, but your script overrides that with your mini red corner that snaps it to the left bottom side of the screen.

woxxomAuthor
§
Posted: 2024-06-12

This is not a feature of my script. I can guarantee it, as an author.

§
Posted: 2024-06-13
Edited: 2024-06-13

I know that...

But your script does show a very small red corner, that when clicked it snaps the video to one of the corners of the screen, that overrides the resizing feature of 495214-youtube-link-to-embedded-video.

Also, as you can see in the GIF, 495214-youtube-link-to-embedded-video has a red X in the right top, that your script erases/hides for some reason

https://imgur.com/a/FQwcb90

§
Posted: 2024-06-13

Just found another unrelated bug https://imgur.com/a/3yjba02

woxxomAuthor
§
Posted: 2024-06-14

I see what you mean, the problem exists because of interaction with some third script, but my script doesn't erase anything. It simply creates its own UI and its own iframe. It's not compatible with other similar scripts by definition and I don't see what I can do about it.

As for invidious, the site is dead. I'll probably just remove the option.

§
Posted: 2024-06-14

There's no third script, only yours and 495214-youtube-link-to-embedded-video

495214-youtube-link-to-embedded-video is not similar to your script at all

woxxomAuthor
§
Posted: 2024-06-14

Yeah, okay, I've lost the numbering. The problem is the same though.

§
Posted: 2024-06-14

I was hoping that you would try to find out the reason and fix it, or give me some tip on how to fix it.

woxxomAuthor
§
Posted: 2024-06-14

But that's not a bug. It's how the script works. The only thing I can do is to skip iframes created by other scripts. The question is whether I add an option for that.

§
Posted: 2024-06-14

Thanks for your quick response!4) Add an id/class, that your script adds when it modifies an iframe.Maybe that will fix the bug? We could try this first.

4) Add an id/class, that your script adds when it modifies an iframe.

Maybe that will fix the bug? We could try this first.

Then your script can check if this id/class exists in the iframe, and if it does, then your script won't run and modify this specific iframe

*NVM Since, I can already track it by using 'instant-youtube-wrapper', I will let you know if that works/fixes the issue or not.

Thanks!

woxxomAuthor
§
Posted: 2024-06-14

It's probably safe for me to skip iframes with position: absolute

woxxomAuthor
§
Posted: 2024-06-14

Although maybe not. Another universal option might be to skip processing within 100ms of click event...

woxxomAuthor
§
Posted: 2024-06-14

BTW you can use shadow DOM in your script, which will make it immune to other scripts such as mine.

§
Posted: 2024-06-14

> It's probably safe for me to skip iframes with position: absolute

I wouldn't say so, because it might work with my script, but not others...

It's hard to make it universal, so I just want mine+yours working together.

Yeah, that is also true, I will try a few things and get back here if you need to do anything.

§
Posted: 2024-06-16
Edited: 2024-06-16

There are a few cases where it really doesn't make sense for your script to run, like on https://yts.mx/movies/look-to-the-light-2024

The iframe is dynamically created, then after an iframe is created, that is when your script runs, but that is pointless because your script was made to help pages load faster, if the page didn't have an iframe after the first onload event ended, then there's no reason to run your script if an iframe was created.

The only case where this would be nice are websites like RSS readers, or when Pagetual is installed and runs.

Would you be able to 100% disable your script on google and on yts, but let it run your script once on RSS readers (only after Pagetual runs for example)

Maybe simple adding //@exclude for google and yts would work

The pages below are hard to find, but these are literally the only pages on google where it would make sense to have your script run
https://www.google.com/search?q=musica+2014&safe=off&uact=5#fpstate=ive&vld=cid:ac464635,vid:eu1Jq5YKrXM,st:0

§
Posted: 2024-06-16

But even that google page is the same as I said earlier, it only makes sense to run your script on it, if the URL has those parameters onload, so if the user clicks somewhere on google and a page with those parameters load, then there's no reason to run your script if this was a user action.

Post reply

Sign in to post a reply.