Greasy Fork

Misdetection on nodejs.org/docs

The header for fs.watch seems to get wrongly detected as a link and mispositioned:

http://nodejs.org/docs/latest/api/fs.html#fs_fs_unwatchfile_filename_listener

I have a strange feeling that .watch might be a tld.

Yes it is. :)

Fixed at version 2.3.18. Added h1...h6 tags into ignore list.

Thanks, but wouldn't it be better to remove some of these exotic tld's until they gain at least some traction? That way, you'd need less hacks than this :)

I came across a page which had an URL in a header-tag, and it wasn't linkified, example: http://jsfiddle.net/x50rkr9d/1/

Checking the link of OP, and now fs.watch is in a span instead of a <h*>-tag, so that workaround isn't helping anymore.

I also noticed a lot of wrongfully linkified phrases elsewhere, mainly because almost every phrase is a TLD these days. ;)

I don't think ignoring tags is going to help with false-positive detection considering the ridiculous amount of valid TLDs.

Currently, the TLDs are generated from:

• http://data.iana.org/TLD/tlds-alpha-by-domain.txt:
• http://www.iana.org/domains/root/db

Maybe we can sort these TLDs by their popularity, and create different set like "common", "uncommon", "never-used", let user chose which set of TLDs to use.

I'm thinking we can use google to get the frequency of occurrence (Query like "site:.com"), or use the table from ISC.

This should be in next major update. :P

BTW, fs.watch in node.js doc doesn't get linkified in my firefox. Could you put a screenshot or something? It might be another issue.

Funny, it's only linkified because I still had nodejs.org on the NoScript-blacklist.
When JS is allowed for nodejs.org, fs.watch is not linkified.
http://i.imgur.com/Tdyyzl6.png