Greasy Fork is available in English.

Youtube - dismiss sign-in

Hide the "sign-in" and cookies dialogs. Prevent the dialogs from pausing the video.

< Feedback on Youtube - dismiss sign-in

Review: OK - script works, but has bugs

§
Posted: 05.04.2021

I am running Tampermonkey v4.12.6132 as userscript manager. Together with your script "Youtube - dismiss sign-in" v0.6.1 there are some warnings from eslint when editing the source code:

Line 39: better use dot-notation
Line 89: some redundant trailing spaces
Line 102: better use dot-notation
Line 110: some redundant trailing spaces
Line 119: Function declared in a loop
Line 149: better use dot-notation

AchernarAuthor
§
Posted: 05.04.2021
Edited: 05.04.2021

Thanks for the report.

"some redundant trailing spaces": I've missed them when cleaning the code (comments, logging, test lines) before releasing an update after the small test phase.

"better use dot-notation": These are the lines with my generated cookie object. Force of habits: I use that technique in other scripts/extensions. In other cases (not here) the cookie name uses a symbol that is not compatible with the dot notation. For example a dash '-'

"Function declared in a loop": I know, but it's safe here.
The remark is valid if the function is "declared" more than once (in successive loops). Here, the loop is broken after the declaration. And the variables are not modified after that. The variables are then stuck in a closure until the "setInterval" is cleared.

Post reply

Sign in to post a reply.