GitHub Issue Comments

A userscript that toggles issues/pull request comments & messages

< Feedback on GitHub Issue Comments

Review: Good - script works

§
Posted: 13 Juni 2016
Edited: 14 Juni 2016

(Suggestion) the filter names that won't have any matches to be displayed in light gray

I'd like to make a suggestion, please: the filter names that don't have any matches in the current page to be displayed in light gray, so that you may easily distinguish which of the filters can be apply to the current page or not.

For example: in a page, if the filters Title changes and Label changes won't hide anything (if enabled), then, to be displayed in light gray.


Additionally to the above suggestion: all filter names to appear in normal font (instead of bold) by default, and in bold to be displayed only those filters that are enabled.

MottiePembuat
§
Posted: 13 Juni 2016

Oh, that sounds like a good idea. I'll see what I can do.

MottiePembuat
§
Posted: 16 Juni 2016
Edited: 16 Juni 2016

Done, try the latest update!

* Note: the "Hide +1s" will always be bright since determining if there are "+1s" is more complicated than just counting elements.

§
Posted: 16 Juni 2016
Edited: 16 Juni 2016

Thanks a lot for implementing my idea !

So, I just tried the script with GM 3.8 in FF 47 (and in TM 4.0.69 in Chrome 51) and unfortunately it doesn't work (neither the Toggle items nor the Hide comments from) :
clicking on any entry does nothing. I only get this in Browser Console:

el is null         GitHub_Toggle_Issue_Comments.user.js:488:9
MottiePembuat
§
Posted: 16 Juni 2016

DOH, please try the latest update.

§
Posted: 16 Juni 2016

It's working great now! Thank you.

Post reply

Sign in to post a reply.