Greasyfork script-set-edit button

Add / Remove script into / from script set directly in GF script info page

< Feedback on Greasyfork script-set-edit button

Question/comment

  1. Userscript Meta does not have @grant GM_unregisterMenuCommand

    ReferenceError: GM_unregisterMenuCommand is not defined

  2. CONFIG['script-sets'].sets[setIndex].scripts.push(this.#sid);

    TypeError: Cannot read properties of undefined (reading 'push')

Why there is a "debugger;". You forgot to remove the debugging?

PYUDNGAuthor
§
Posted: 2024-07-12
Edited: 2024-07-12

Userscript Meta does not have @grant GM_unregisterMenuCommand

ReferenceError: GM_unregisterMenuCommand is not defined

CONFIG['script-sets'].sets[setIndex].scripts.push(this.#sid);

TypeError: Cannot read properties of undefined (reading 'push')

Tried to fix these two.

Why there is a "debugger;". You forgot to remove the debugging?

Thats my mistake, I forgot to remove it after debugging. Now removed in the update.

§
Posted: 2024-07-12
Edited: 2024-07-12

The "undefined scripts" error still happen when I try to remove the script from the set or favourite.

I have checked the the script is actually removed from the set/favourite in GreasyFork.

(Add is fine.)

I have noticed that needRefresh && this.#refresh(); is only in #addFav() but not in #removeFav(). Is this the reason?

PYUDNGAuthor
§
Posted: 2024-07-13

I have noticed that needRefresh && this.#refresh(); is only in #addFav() but not in #removeFav(). Is this the reason?

Maybe, so I added the refresh for #removeFav() too in last update. But in fact I still cannot understand why this is happening, because this never happened in my browser(Tampermonkey, Chrome, MacOS).

It seemed only sets itself stored in GM value, but its property set.scripts missing in storage. It's weird, because sets and their scripts should be stored together in one request and in one line of code (code line 720 in version 0.2.8.5).

Which browser and script manager are you using?

§
Posted: 2024-07-13
Edited: 2024-07-13

But in fact I still cannot understand why this is happening, because this never happened in my browser(Tampermonkey, Chrome, MacOS).

inside #refresh_doc(), CONFIG['script-sets'].sets[setIndex].scripts = set.scripts; is the place that setting .scripts

The scripts property does not exist in getScriptSets

so #refresh_doc() is required otherwise CONFIG['script-sets'].sets[...].scripts is undefined.

Which browser and script manager are you using?

MacOS. Violentmonkey

Anyway, the issue seems got in 0.2.8.5. Thanks

Post reply

Sign in to post a reply.