Linkify Plus Plus

Based on Linkify Plus. Turn plain text URLs into links.

< Feedback on Linkify Plus Plus

Review: Good - script works

§
Posted: 2014-11-04
Edited: 2015-01-13

Stops before parentheses (2.3.22) - FIXED

"(" and ")" are valid characters within URLs. https://tools.ietf.org/html/rfc1738#page-4

Thus, only alphanumerics, the special characters "$-_.+!*'(),", and reserved characters used for their reserved purposes may be used unencoded within a URL.

This regularly breaks linkification of wikipedia-links, which tend to have parentheses, i.e. http://en.wikipedia.org/wiki/Darwin(operatingsystem)

Though I don't know if it's feasible to make sure that no stray parenthesis will be linkified, e.g. so (http://www.foobar.com/test) doesn't end up linking to http://www.foobar.com/test).

EDIT: Maybe the regexs of John Gruber may be helping: http://daringfireball.net/2010/07/improvedregexformatchingurls and their forks It also got good test-data.

eightAuthor
§
Posted: 2014-11-05

Fixed at version 2.3.23. I loop through URL to check if there are any invalid parentheses.

§
Posted: 2015-01-06
Edited: 2015-01-13

Thanks, working fine.

EDIT:
If anyone wonders why the Darwin-link in the OP isn't properly linkified: That's the website's linkification being dumb. ;)

Post reply

Sign in to post a reply.